Skip to content

Fix: Adds inline to Fonts Tailwind v4 instructions #11491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025

Conversation

JusticeMatthew
Copy link
Contributor

Description (required)

Changes @theme {} instructions for tailwind to @theme inline {} per the tailwind docs:
https://tailwindcss.com/docs/theme#referencing-other-variables

Related issues & labels (optional)

Copy link

netlify bot commented Apr 19, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5acacfd
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/68064854db54f200080e1a8f
😎 Deploy Preview https://deploy-preview-11491--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 19, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works. Although, I'm not sure there's any other benefit than shipping one fewer css variables?

Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918
Copy link
Member

If @florian-lefebvre approves this change from a technical standpoint, then it's fine by me!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) code snippet update Updates a code sample: typo, outdated code etc. labels Apr 19, 2025
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great

@sarah11918 sarah11918 merged commit cd9070a into withastro:main Apr 21, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 21, 2025
@JusticeMatthew JusticeMatthew deleted the patch-1 branch April 22, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind @theme + new Fonts needs inline
5 participants